carlosluis / multiagent_planning

Implementation of several multiagent trajectory generation algorithms
GNU General Public License v3.0
87 stars 23 forks source link

Getting rid of the Communications System Toolbox #2

Open bttner opened 5 years ago

bttner commented 5 years ago

Hey,

Thank you so much for your work. I really appreciate it.

However, you make use of the function vec2mat, which requires the Communications System Toolbox. Since not all people have it installed I believe (like me), it may be a good idea to replace the function with reshape (built-in and I think also faster). E.g.,

p = reshape(p, 3, []);
v = reshape(v, 3, []);
a = reshape(a, 3, []);

a(:,:,i) = reshape(ai', 3, []);
p(:,:,i) = reshape(pi, 3, []);
v(:,:,i) = reshape(vi, 3, []);

I changed all respective lines and got good results. What do you think?

Otherwise, thank you for sharing your code. It helped me a lot.

Best regards Felix

carlosluis commented 5 years ago

Hi Felix,

Thank you for contacting me and apologies for the delayed response.

Indeed, that's a good alternative. I didn't realize the function belonged to a non-stock toolbox of MATLAB.

If you feel like it, you can create a pull request with the changes and I'll merge it.

Best, Carlos

On Sat, 5 Oct 2019 at 15:45, Felix Büttner notifications@github.com wrote:

Hey,

Thank you so much for your work. I really appreciate it.

However, you make use of the function vec2mat, which requires the Communications System Toolbox. Since not all people have it installed I believe (like me), it may be a good idea to replace the function with reshape (built-in and I think also faster). E.g.,

p = reshape(p, 3, []); v = reshape(v, 3, []); a = reshape(a, 3, []);

a(:,:,i) = reshape(ai', 3, []); p(:,:,i) = reshape(pi, 3, []); v(:,:,i) = reshape(vi, 3, []);

I changed all respective lines and got good results. What do you think?

Otherwise, thank you for sharing your code. It helped me a lot.

Best regards Felix

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/carlosluisg/multiagent_planning/issues/2?email_source=notifications&email_token=AD235DCW4HK4JAXEI4PHE23QNCK57A5CNFSM4I5XZHDKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HP2URFA, or mute the thread https://github.com/notifications/unsubscribe-auth/AD235DC2HCGPHGQUUEO3NSDQNCK57ANCNFSM4I5XZHDA .

-- Carlos Luis, MSc Student Dynamic Systems Lab http://dynsyslab.org - University of Toronto Mobile: (+1)514-229-9766 LinkedIn https://www.linkedin.com/in/carlos-luis/