search

carlosrsabreu / devo-abastecer

Twitter bot that publishes weekly the fuel prices updates on Madeira island.
https://twitter.com/devoabastecer
MIT License
10 stars 2 forks source link

[FIX]: Issue #17 #18

Closed HarryVasanth closed 1 year ago

HarryVasanth commented 1 year ago

Related issues

Closes #17

What does this PR do?

This PR addresses all the issues mentioned on #17 and is solving the following issues:

  1. Currently, the GitHub workflow main.yml is failing. Extract data from DRTT

  2. The file history/img/plot.png doesn't exist in the repository.

  3. However, the workflow is still referring to it and attempts to make a commit: https://github.com/carlosrsabreu/devo-abastecer/blob/010431a06eb908acff66d6f896f3b8f15e87dff9/.github/workflows/main.yml#L36

Solution Overview

Implementation Details

This is the quick and clean way 😉

Dntfreitas commented 1 year ago

Sorry about this, @HarryVasanth

I overlooked that 😭

All those changes look perfect to me 🙏

HarryVasanth commented 1 year ago

Haha, no worries. It happens to all of us, and it's never the PR's fault, but the reviewers. You could stare 👀 judging at the reviewer 👉 @joaoofreitas @carlosrsabreu 👈

🤣

joaoofreitas commented 1 year ago

I'm a rookie at pipelining. 🤣

HarryVasanth commented 1 year ago

Maybe in the future we can try these plots: https://github.com/RainCloudPlots/RainCloudPlots

Also, @Dntfreitas / @carlosrsabreu, I think it'll be better if you enable Discussions on this repo. Easier to discuss stuff and weigh-in opinions; what do you think?