Closed HarryVasanth closed 1 year ago
LGTM
Looks awesome!! Nice work!
Just a note: is there a way to create a lint file in this project so these rules would be applied when someone changes and saves the file locally? This way, the number of PRs to accept and the chances of someone having the code formatted in the "wrong" way would be less. Let me know your thoughts, @HarryVasanth
There are no specific lint config for this. For py
, literally the whole world uses Black and it is available as a linter in all the mainstream code editors. The json
and md
files are formatted using Prettier which has more than 5.2 million dependant projects.
After speaking with @carlosrsabreu, I am removing the additional step of approving the pull-request
created by the black formatter. From now on, all the file types in the workflow (json, md, py) that are pushed to the main
branch will be formatted accordingly.
Related issues
Closes #21
What does this PR do?
Solution Overview
Implementation Details