search

carlossg / docker-maven

Official Docker image with Maven
Apache License 2.0
515 stars 422 forks source link

eclipse-temurin images have no gpg binaries #256

Open btheu opened 2 years ago

btheu commented 2 years ago

Hi,

Moving the build pipeline usage from maven:3.8-openjdk-17 to maven:3.8-eclipse-temurin-17 makes open source projects failing.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-gpg-plugin:1.6:sign (sign-artifacts) on project futurefit: Unable to execute gpg command: Error while executing process. Cannot run program "/usr/bin/gpg": error=2, No such file or directory -> [Help 1]

This is at gpg signing time before deploying to maven central.

Since gpg is a standard tool for signing maven artifacts, shouldn't it be included to maven eclipse-temurin images like maven:3.8-openjdk-17 ?

Regards,

carlossg commented 2 years ago

the images have the bare minimum, some images don't even have git

dkowis commented 1 year ago

Could it be codified what binaries come standard on the image?

Some have git and some don't, and consistency, in either direction, would be super nice to have. Thanks!

carlossg commented 1 year ago

right now they have what comes from the parent images and it is tested under https://github.com/carlossg/docker-maven/blob/master/tests/tests.bats#L63-L140

I'm not keen on installing extra packages as that could open a can of worms

dkowis commented 1 year ago

Does this mean that all images will have this minimal baseline of packages, or will the tests be tailored to each upstream?

Thanks!

carlossg commented 1 year ago

tests are tailored to each upstream