search

carlossg / docker-maven

Official Docker image with Maven
Apache License 2.0
524 stars 423 forks source link

Create windows Dockerfile generator and add images #341

Closed slide closed 1 year ago

slide commented 1 year ago

This adds a powershell script to generate the Windows Dockerfiles and adds some additional images (including a fix for #236). To generate the Windows Dockerfiles, you can run:

.\windows-assets\generate-windows-files.ps1 -MavenVersion '3.9.0' -MavenHash 'THEHASHFORMAVEN.ZIP'

This will generate the directories, Dockerfiles and github action templates for the items defined in windows-image-configs.json.

slide commented 1 year ago

Looks like ltsc2022 isn't supported on GH Actions

carlossg commented 1 year ago

I don't have access to a windows box so it's going to be hard for me to support this setup

slide commented 1 year ago

I guess a shell script would be better then?

carlossg commented 1 year ago

yeah for the generation definitely

I'm moving the linux images to use one main image to build and use COPY --from in the other ones based on Docker recommendation https://github.com/docker-library/official-images/pull/14083#issuecomment-1433740677

I have some work in progress that will push soon. I don't know if something like this is possible in Windows

slide commented 1 year ago

Ok, I'll wait and see what it looks like.