Closed anirbanmu closed 1 year ago
@carlossg looks like the tests assert that gpg is installed, so looks like I should leave it installed in these images too, yes? I was removing it after being done with what I needed it for.
I prefer to have the bare minimum in the images. The tests are to check for regressions, but for new images they can be changed if gpg is not in the image
I prefer to have the bare minimum in the images. The tests are to check for regressions, but for new images they can be changed if gpg is not in the image
Makes sense, I will change the test & remove curl
& gpg
from the image after the steps I'm using them in. Will push up another commit in a bit.
Removed both curl & gpg, and updated the tests to reflect that.
I've rebased against latest master just now to keep the PR up-to-date.
@carlossg let me know if there's more changes to be made on this branch before being mergable & I can definitely make them.
thanks!
Thanks for merging this @carlossg. How will the process go about seeing if official dockerhub maintainers will take these new images or not? I see instructions for that here -- https://github.com/carlossg/docker-maven#publishing-to-docker-hub -- do you want to handle that or let me know if you want me to do something about that?
Sounds great, thank you much. Will follow along there.
👋 Here's a PR with a first attempt at generating amazoncorretto images from upstream
debian:stable-slim
. I've generated the github actions workflows & updated the README as well.Let me know how it looks & I'm always happy to make any changes you suggest.
Leaving the issue link here where this was discussed prior -- https://github.com/carlossg/docker-maven/issues/346