carlossg / docker-maven

Official Docker image with Maven
Apache License 2.0
524 stars 423 forks source link

Verify corretto apt key & make corretto-20-debian image install the java-20 package #360

Closed anirbanmu closed 1 year ago

anirbanmu commented 1 year ago

@carlossg I saw the comment on https://github.com/docker-library/official-images/pull/14308#issuecomment-1496758237 about passing downloaded keys via gpg so I've tried to do that here in this PR.

I also changed the corretto-20-debian image to install java-20-amazon-correto-jdk -- I think it was accidentally installing 19.

anirbanmu commented 1 year ago

I think the tests are failing due to not finding the maven:3.9.1-eclipse-temurin-11 image, which I think may be expected at the moment.

anirbanmu commented 1 year ago

As a sidenote -- let me know if you'd like to change the debian images to all inherit from debian:bullseye-slim rather than debian:stable-slim (as I think another part of the comment suggested). I can attempt to make that change in a separate PR.