Closed anirbanmu closed 1 year ago
LGTM just confirming in https://github.com/docker-library/official-images/pull/14308#issuecomment-1506894614
thanks!
actually looks like the Architectures are wrong and s390x is in there
❯ ./generate-stackbrew-library.sh | grep -A 3 'Tags.*amazoncorretto-.*-debian'
Tags: 3.9.1-amazoncorretto-11-debian, 3.9.1-amazoncorretto-11-debian-bullseye, 3.9-amazoncorretto-11-debian, 3.9-amazoncorretto-11-debian-bullseye, 3-amazoncorretto-11-debian, 3-amazoncorretto-11-debian-bullseye
Architectures: amd64, arm64v8, s390x
GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8
Directory: amazoncorretto-11-debian
--
Tags: 3.9.1-amazoncorretto-17-debian, 3.9.1-amazoncorretto-17-debian-bullseye, 3.9-amazoncorretto-17-debian, 3.9-amazoncorretto-17-debian-bullseye, 3-amazoncorretto-17-debian, 3-amazoncorretto-17-debian-bullseye
Architectures: amd64, arm64v8, s390x
GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8
Directory: amazoncorretto-17-debian
--
Tags: 3.9.1-amazoncorretto-19-debian, 3.9.1-amazoncorretto-19-debian-bullseye, 3.9-amazoncorretto-19-debian, 3.9-amazoncorretto-19-debian-bullseye, 3-amazoncorretto-19-debian, 3-amazoncorretto-19-debian-bullseye
Architectures: amd64, arm64v8, s390x
GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8
Directory: amazoncorretto-19-debian
--
Tags: 3.9.1-amazoncorretto-20-debian, 3.9.1-amazoncorretto-20-debian-bullseye, 3.9-amazoncorretto-20-debian, 3.9-amazoncorretto-20-debian-bullseye, 3-amazoncorretto-20-debian, 3-amazoncorretto-20-debian-bullseye
Architectures: amd64, arm64v8, s390x
GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8
Directory: amazoncorretto-20-debian
--
Tags: 3.9.1-amazoncorretto-8-debian, 3.9.1-amazoncorretto-8-debian-bullseye, 3.9-amazoncorretto-8-debian, 3.9-amazoncorretto-8-debian-bullseye, 3-amazoncorretto-8-debian, 3-amazoncorretto-8-debian-bullseye
Architectures: amd64, arm64v8, s390x
GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8
Directory: amazoncorretto-8-debian
actually looks like the Architectures are wrong and s390x is in there
❯ ./generate-stackbrew-library.sh | grep -A 3 'Tags.*amazoncorretto-.*-debian' Tags: 3.9.1-amazoncorretto-11-debian, 3.9.1-amazoncorretto-11-debian-bullseye, 3.9-amazoncorretto-11-debian, 3.9-amazoncorretto-11-debian-bullseye, 3-amazoncorretto-11-debian, 3-amazoncorretto-11-debian-bullseye Architectures: amd64, arm64v8, s390x GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8 Directory: amazoncorretto-11-debian -- Tags: 3.9.1-amazoncorretto-17-debian, 3.9.1-amazoncorretto-17-debian-bullseye, 3.9-amazoncorretto-17-debian, 3.9-amazoncorretto-17-debian-bullseye, 3-amazoncorretto-17-debian, 3-amazoncorretto-17-debian-bullseye Architectures: amd64, arm64v8, s390x GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8 Directory: amazoncorretto-17-debian -- Tags: 3.9.1-amazoncorretto-19-debian, 3.9.1-amazoncorretto-19-debian-bullseye, 3.9-amazoncorretto-19-debian, 3.9-amazoncorretto-19-debian-bullseye, 3-amazoncorretto-19-debian, 3-amazoncorretto-19-debian-bullseye Architectures: amd64, arm64v8, s390x GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8 Directory: amazoncorretto-19-debian -- Tags: 3.9.1-amazoncorretto-20-debian, 3.9.1-amazoncorretto-20-debian-bullseye, 3.9-amazoncorretto-20-debian, 3.9-amazoncorretto-20-debian-bullseye, 3-amazoncorretto-20-debian, 3-amazoncorretto-20-debian-bullseye Architectures: amd64, arm64v8, s390x GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8 Directory: amazoncorretto-20-debian -- Tags: 3.9.1-amazoncorretto-8-debian, 3.9.1-amazoncorretto-8-debian-bullseye, 3.9-amazoncorretto-8-debian, 3.9-amazoncorretto-8-debian-bullseye, 3-amazoncorretto-8-debian, 3-amazoncorretto-8-debian-bullseye Architectures: amd64, arm64v8, s390x GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8 Directory: amazoncorretto-8-debian
Oh oops, I guess it's the last architecture in the list, so the replace including comma does not work. Let me fix in a second.
I've done the following in this PR:
amazoncorretto-*-debian-slim
to justamazoncorretto-*-debian
bullseye
suffix so one can pin to that to guard against surprise upgrade to next stableLet me know what you think of all this; of course, I'm happy to make any changes you suggest.