search

carlossg / docker-maven

Official Docker image with Maven
Apache License 2.0
524 stars 423 forks source link

Remove s390x for amazoncorretto-*-debian actually #363

Closed anirbanmu closed 1 year ago

anirbanmu commented 1 year ago

@carlossg can you see if this works for the moment? Unfortunately, my current dev env is not set up properly to run generate_stackbrew_library.sh 😔.

I can try to make a cleaner fix later that doesn't assume the order of the architectures (probably something like put them in a bash array, loop through them and only take what we need).

anirbanmu commented 1 year ago

Actually, no this won't work since it will leave the comma at the end. Let me try to do the full fix.

carlossg commented 1 year ago

I gave it a try but it is not yet right as the array keeps empty elements and cannot spend more time today on it

Tags: 3.9.1-amazoncorretto-8-debian, 3.9.1-amazoncorretto-8-debian-bullseye, 3.9-amazoncorretto-8-debian, 3.9-amazoncorretto-8-debian-bullseye, 3-amazoncorretto-8-debian, 3-amazoncorretto-8-debian-bullseye
Architectures: amd64, , , arm64v8, , , ,
GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8
Directory: amazoncorretto-8-debian
anirbanmu commented 1 year ago

Thanks for trying, I will play with it to see what I can come up with.

anirbanmu commented 1 year ago

Ok @carlossg I think latest commit works, I just did it via a loop + producing a new filteredArches array. I fixed my dev env to be able to generate the stackbrew library & it's producing things like

Tags: 3.9.1-amazoncorretto-8-debian, 3.9.1-amazoncorretto-8-debian-bullseye, 3.9-amazoncorretto-8-debian, 3.9-amazoncorretto-8-debian-bullseye, 3-amazoncorretto-8-debian, 3-amazoncorretto-8-debian-bullseye
Architectures: amd64, arm64v8
GitCommit: 7325174827898b1a02c0edfb1535a3a0595992b8
Directory: amazoncorretto-8-debian

Tags: 3.9.1-sapmachine-11, 3.9-sapmachine-11, 3-sapmachine-11
Architectures: amd64, arm64v8, ppc64le
GitCommit: 8f9adaf3d78df6ed956b0a717d51876f71f0fdfe
Directory: sapmachine-11

Tags: 3.9.1-sapmachine-17, 3.9.1-sapmachine, 3.9-sapmachine-17, 3.9-sapmachine, 3-sapmachine-17, 3-sapmachine, sapmachine
Architectures: amd64, arm64v8, ppc64le
GitCommit: 8f9adaf3d78df6ed956b0a717d51876f71f0fdfe
Directory: sapmachine-17

which looks right to me? Full generate-stackbrew-library.sh output is here -- https://gist.github.com/anirbanmu/8e8e5623417f52c2a183e1e413bc4fa7