carlossg / docker-maven

Official Docker image with Maven
Apache License 2.0
518 stars 424 forks source link

Please add amazoncorretto + al2023 images #392

Closed wkruse closed 10 months ago

wkruse commented 11 months ago

There are official Amazon Corretto images based on Amazon Linux 2023:

  1. 8-al2023
  2. 11-al2023
  3. 17-al2023
  4. 20-al2023

Could you please add 8-amazoncorretto-al2023, 11-amazoncorretto-al2023, 17-amazoncorretto-al2023 and 20-amazoncorretto-al2023 images?

Current Maven images with Amazon Corretto JDK are based on Amazon Linux 2, which includes GNU libc 2.26:

docker run --rm maven:3-amazoncorretto-17 cat /etc/os-release
NAME="Amazon Linux"
VERSION="2"
ID="amzn"
ID_LIKE="centos rhel fedora"
VERSION_ID="2"
PRETTY_NAME="Amazon Linux 2"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2"
HOME_URL="https://amazonlinux.com/"
docker run --rm maven:3-amazoncorretto-17 ldd --version
ldd (GNU libc) 2.26

Because of that, for exampe NodeJS v20.x install is not supported:

node: /lib64/libm.so.6: version `GLIBC_2.27' not found (required by node)
node: /lib64/libc.so.6: version `GLIBC_2.28' not found (required by node)

But current Amazon Corretto Amazon Linux 2023 include GNU libc 2.34:

docker run --rm amazoncorretto:17-al2023 cat /etc/os-release
NAME="Amazon Linux"
VERSION="2023"
ID="amzn"
ID_LIKE="fedora"
VERSION_ID="2023"
PLATFORM_ID="platform:al2023"
PRETTY_NAME="Amazon Linux 2023"
ANSI_COLOR="0;33"
CPE_NAME="cpe:2.3:o:amazon:amazon_linux:2023"
HOME_URL="https://aws.amazon.com/linux/"
BUG_REPORT_URL="https://github.com/amazonlinux/amazon-linux-2023"
SUPPORT_END="2028-03-01"
docker run --rm amazoncorretto:17-al2023 ldd --version
ldd (GNU libc) 2.34

which does support NodeJS v20.x install.

wkruse commented 11 months ago

I would be happy to provide a PR, if needed.

carlossg commented 11 months ago

hi, if you would provide a PR I can add them to the builds, thanks!