feat: add ssh client package needed by maven release plugin

[timothystone-knsl]

Consume upstream changes from dacr repository. Branch, resolve conflicts, and add openssh-clients to new images using appropriate package manager.

Update README SSH column.

Fixes #378

[carlossg]

thanks, I don't have permission to update the PR, can you change the line https://github.com/carlossg/docker-maven/blob/main/tests/tests.bats#L169 to assert_success ?

[carlossg]

liberica is failing

# #8 [stage-0 2/6] RUN yum install -y openssh-clients
# #8 0.284 Loaded plugins: fastestmirror, ovl
# #8 0.350 Determining fastest mirrors
# #8 0.363 Could not retrieve mirrorlist http://mirrorlist.centos.org/?release=7&arch=x86_64&repo=os&infra=container error was
# #8 0.363 14: curl#6 - "Could not resolve host: mirrorlist.centos.org; Unknown error"
# #8 0.3[65](https://github.com/carlossg/docker-maven/actions/runs/9957305476/job/27510375460?pr=480#step:8:66)
# #8 0.365
# #8 0.365  One of the configured repositories failed (Unknown),
# #8 0.365  and yum doesn't have enough cached data to continue. At this point the only
# #8 0.365  safe thing yum can do is fail. There are a few ways to work "fix" this:
# #8 0.365
# #8 0.365      1. Contact the upstream for the repository and get them to fix the problem.
# #8 0.365
# #8 0.365      2. Reconfigure the baseurl/etc. for the repository, to point to a working
# #8 0.365         upstream. This is most often useful if you are using a newer
# #8 0.365         distribution release than is supported by the repository (and the
# #8 0.365         packages for the previous distribution release still work).
# #8 0.365
# #8 0.365      3. Run the command with the repository temporarily disabled
# #8 0.365             yum --disablerepo=<repoid> ...
# #8 0.365
# #8 0.365      4. Disable the repository permanently, so yum won't use it by default. Yum
# #8 0.365         will then just ignore the repository until you permanently enable it
# #8 0.365         again or use --enablerepo for temporary usage:
# #8 0.365
# #8 0.365             yum-config-manager --disable <repoid>
# #8 0.365         or
# #8 0.365             subscription-manager repos --disable=<repoid>
# #8 0.365
# #8 0.365      5. Configure the failing repository to be skipped, if it is unavailable.
# #8 0.365         Note that yum will try to contact the repo. when it runs most commands,
# #8 0.365         so will have to try and fail each time (and thus. yum will be be much
# #8 0.365         slower). If it is a very temporary problem though, this is often a nice
# #8 0.365         compromise:
# #8 0.365
# #8 0.365             yum-config-manager --save --setopt=<repoid>.skip_if_unavailable=true
# #8 0.365
# #8 0.365 Cannot find a valid baseurl for repo: base/7/x[86](https://github.com/carlossg/docker-maven/actions/runs/9957305476/job/27510375460?pr=480#step:8:87)_64
# #8 ERROR: process "/bin/sh -c yum install -y openssh-clients" did not complete successfully: exit code: 1

[timothystone-knsl]

liberica is failing ...snip...

@carlossg Liberica failures in CentOS only. Looks related to this comment on ServerFault. Looking at path to resolution.

Working on it.

[timothystone-knsl]

liberica is failing ...snip...

@carlossg Liberica failures in CentOS only. Looks related to this comment on ServerFault. Looking at path to resolution.

Working on it.

@carlossg so it appears that Liberica has not updated the CentOS images in three months. That's fine... I guess. But this change appears to about two weeks old and Liberica may drop a change. I'll try to monitor it.

I've got a patch inbound for your review based on the idea proposed in the ServerFault comment. Going to test it locally, then push.

[timothystone-knsl]

liberica is failing ...snip...

@carlossg Liberica failures in CentOS only. Looks related to this comment on ServerFault. Looking at path to resolution. Working on it.

@carlossg so it appears that Liberica has not updated the CentOS images in three months. That's fine... I guess. But this change appears to about two weeks old and Liberica may drop a change. I'll try to monitor it.

I've got a patch inbound for your review based on the idea proposed in the ServerFault comment. Going to test it locally, then push.

It's far more complicated. Liberica CentOS distros are building from 7.9.2009 which is EOL and not getting security updates.

How does the project determine removal of build support when upstream projects get stale?

[carlossg]

I'll remove them

[timothystone-knsl]

I'll remove them

Do you want me to remove them from PR, or is there another process to handle post PR merge?

[carlossg]

when #481 is merged you'll need to rebase and solve conflicts

[timothystone-knsl]

Working on the update.

[timothystone-knsl]

Working on the update.

Ready to kick off the workflows I think.

[chtompki]

I could use this patch. Definitely +1 for it being migrated in

[carlossg]

@timothystone could you allow maintainers edits to the PR as I'd like to squash this into one commit and rebase it? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

[timothystone-knsl]

@timothystone could you allow maintainers edits to the PR as I'd like to squash this into one commit and rebase it? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests

Of course. Working on it.

Update... odd... it's checked per the documentation:

[image deleted]

D'oh, my upstream is not this repository. Let me fix that (I'll make you a Collaborator for the moment).

Made you a collaborator for the time being. Some background, I forked from David's original fork. David opened his PR from main to this main. Then I defined the upstream to this repo locally, i.e., git remote add upstream ... and sync'd, branched, and opened the PR. (I hindsight there's a better way of doing that, but I'm sort of stuck at the moment). Sorry.

Update

Helping out here. There's an invite to the project in your mailbox. I'm rebasing through the README.md conflicts.

[timothystone-knsl]

I can recreate on a "properly forked" repository if necessary. Sorry for the mess and overhead.

[timothystone-knsl]

Closing. See #482.