search

carlossless / smk

A keyboard firmware for sinowealth-8051-based devices
GNU General Public License v2.0
46 stars 4 forks source link

working on royal kludge rk61 rgb wired #3

Open timaxur opened 6 months ago

timaxur commented 6 months ago

Thank you for this! My rk61 is working beautifully with it, I traced the pcb connections between the key switches and the mcu. I haven't traced the led connections, though. I will probably post more details later, github blocked my main account with their 2fa crap and I'm going out of here to greener pastures for my taste (probably codeberg), but I want to report one bug that may affect you too and I "fixed" by changing line 70 of src/matrix.c to: 

clear_keys(); action_layer=0;

instead of just "action_layer=0;". Otherwise my keyboard doesn't register the appropriate key release after pressing:

  1. press: momentary key (change layer)
  2. press: any key mapped on the new layer
  3. release: momentary key
  4. release: they key mapped on the new layer (2)

Thanks again, Nicolas

carlossless commented 6 months ago

Hey,

Thanks for the report! I'm very much looking forward to incorporating more keyboards like the RK61 into the firmware, so I'm eagerly awaiting those details.

Thanks for pointing out the bug and fix. I'm not yet using this keyboard as one of my mains, so there are likely more issues with the firmware, not to mention features that are still unimplemented, NKRO, LEDs, etc...

timaxur commented 6 months ago

hey, I uploaded the mods I did for the RK61 to https://codeberg.org/nicarran/smk branch nicarran-rk61. It was basically a smooth ride to make it work after tracing the switches. I don't really miss more features, although nkro would be sweet. If there are new SMK versions including RK61 support I will be happy to test and report back. Thank you!

carlossless commented 5 months ago

@timaxur I looked over your changes - nice job!

I am working on modularising this codebase. Once I am done I hope it will make it easier to maintain several different keyboards (and other sinowealth 8051 mcus) in this codebase.

Once I am at that point, I would then ask you to upstream your changes, if you're able to that is!

carlossless commented 2 weeks ago

@timaxur I've made adjustments to this project enough to say that it's ready to accept more keyboard configs, including yours. Would you be willing to port your changes to the newly updated version?

timaxur commented 1 day ago

Sweet... I ported the changes and everything went smoothly. You can find them at https://codeberg.org/nicarran/smk.git in the branch nicarran-rk61-v2 (https://codeberg.org/nicarran/smk/commits/branch/nicarran-rk61-v2). Feel free to make changes and use them as required. I can give you feedback and continue testing the keyboard. Thank you!

(update: had to do another commit, sorry, now I won't touch that branch again ;-S )