search

carlsednaoui / add-to-calendar-buttons

Easily add a "add to calendar" button to your websites. This JavaScript library supports Google Calendar, iCal, Outlook and Yahoo Calendar.
476 stars 171 forks source link

IE7/IE8 javascript error #3

Open marcovtwout opened 10 years ago

marcovtwout commented 10 years ago

https://github.com/carlsednaoui/add-to-calendar-buttons/blob/master/ouical.js#L151

Class is a reserved keyword. Replace by:

params.options["class"]

marcovtwout commented 10 years ago

Even better: rename the keyword to something non-reserved, like "cssClass"

carlsednaoui commented 10 years ago

Good call!

I'll be reviewing this lib in the coming weeks. Let me know if you have any other feedback. Thanks @marcovtwout!