search

carlsednaoui / add-to-calendar-buttons

Easily add a "add to calendar" button to your websites. This JavaScript library supports Google Calendar, iCal, Outlook and Yahoo Calendar.
476 stars 171 forks source link

IE8 compatibility #4

Open marcovtwout opened 10 years ago

marcovtwout commented 10 years ago

IE8 is still widely used, unfortunately your plugin is not compatible ;)

I found the following errors:

Would you care about fixing those?

marcovtwout commented 10 years ago

After patching these myself, I also found the "hack" where you use a checkbox to hide/show calendar items also does not work in IE8..

mchandleraz commented 10 years ago

Hey Marco,

Did you end up finding an alternative or solution for IE8?

carlsednaoui commented 10 years ago

Hi @mchandleraz, I'm actually re-writing this library from the ground up. That should hopefully help take care of that nasty bug.

Branch with work in progress: https://github.com/carlsednaoui/add-to-calendar-buttons/tree/refactor

As a side note, @marcovtwout mentioned that he ended up patching the errors himself. Perhaps he can share the end result :)

marcovtwout commented 10 years ago

If you are rewriting this library, my patches shouldn't be needed. :)

Just take a close look at any javascript functions you are using and if they are supported by your target browsers. I recommend following the MDN documentation, for example: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/forEach

carlsednaoui commented 10 years ago

@marcovtwout I know that, was just trying to save @mchandleraz some time. (Won't be a few weeks until the new version is out.)

mchandleraz commented 10 years ago

@marcovtwout @carlsednaoui thanks for the replies. I ended up just dropping the add to calendar feature from this project for this version because we were running out of time. I'll keep my eye on the new library though.

ptim commented 10 years ago

I'm looking forward to the new version, too :+1:

carlsednaoui commented 10 years ago

Sorry for the slack on this, been busy with https://github.com/carlsednaoui/ouibounce and other projects :cry: Will definitely put some hours into the new version soon!

marcovtwout commented 9 years ago

As requested, here is my patched and unsupported version created one year ago: http://pastebin.com/JeC9etZc

carlsednaoui commented 9 years ago

@marcovtwout could you please send a PR?

marcovtwout commented 9 years ago

Sorry, as I said earlier, I really just patched things quickly, I don't think it is PR worthy.