carlsednaoui / nycio

NYC Tech Volunteer Database
6 stars 2 forks source link

New Collaborator #13

Closed mattjstar closed 10 years ago

mattjstar commented 10 years ago

First of all, I'm super excited to get started working with the two of you on this project. Just wanted to follow up with the talk I had with Carl as we discussed a lot of potential changes.

1) Victor, I completely agree that we shouldn't use ActiveAdmin. I think building from scratch is definitely the way to go. I tried ActiveAdmin on my most recent app (scout.rawrdenim.com) and after only a week started running into trouble, so I just built it myself from scratch and am definitely glad I did.

2) I noticed that we already upgraded to ruby 2.1.0, should we upgrade to ruby 2.1.1 and Rails 4.0.4 to stay up to date?

3) Considering we're not using ActiveAdmin should we delete it or should we just start over with a brand new Rails 4.0.4/Ruby 2.1.1 app?

4) For the new admin side I would still use Devise and CanCan for authorization and authentication (I'm open to whatever, I've just had a great experience with those two gems)

5) How did we want to deal with User roles? For the scout I just created one table called Users and added a roles column, and then used cancan for authorization (so we could have a Users table or AdminUsers table with "super_admin" and "organization_admin" roles)

***Let me know if you guys want to see the admin side of the scout to get a better sense of what I did.

miclovich commented 10 years ago

Hi Matt, will comment inline

[2] +1 on the update to ruby 2.1.1 :dart:

[4][5] We had a similar idea as well; and also include the rolify gem for the roles assignments such as Volunteer and Admin roles (and SuperAdmin). Perhaps we can pair on a branch I recently started, was meaning to get some free time to contribute between now and Monday. Look at the feature/admin-dashboard branch; yep we decided to work with git-flow

carlsednaoui commented 10 years ago

So glad to be working with you both. Looking forward to our Google hangout session next week!

carlsednaoui commented 10 years ago

Closing this issue for now. Feel free to re-open if needed.