search

carlsednaoui / nycio

NYC Tech Volunteer Database
6 stars 2 forks source link

ignore: Refactor adding/deleting UserSkill's #30

Closed mattjstar closed 10 years ago

mattjstar commented 10 years ago

Refactor logic for adding and deleting UserSkill's in users#update from the User edit page. Seems a bit too bootstrappy to me.

    if skill_id_params.present?
        original_array = @user.user_skills.pluck(:skill_id)
        skill_id_params.each do |skill_id|
            UserSkill.find_or_create_by(user_id: @user.id, skill_id: skill_id)
        end
        (original_array - skill_id_params).each do |skill_id|
            UserSkill.where(user_id: @user.id, skill_id: skill_id)[0].destroy
        end
    end