carlsednaoui / nycio

NYC Tech Volunteer Database
6 stars 2 forks source link

Final Phase 1 Push #35

Closed carlsednaoui closed 10 years ago

carlsednaoui commented 10 years ago
mattjstar commented 10 years ago

@miclovich I'm gonna do as much as I can of this stuff over the next hour or so. I'll keep you guys posted as I finish features and push them up!

mattjstar commented 10 years ago

I was able to get Event creation and editing working (complete with authentication and authorization, only Organization managers can add and edit events for their organizations, admins can add and edit events for any organizations). I don't know how much time I'll have left today.

We still need to add Occurrences and Skills to Event creation and editing.

Also check out the home page. I'm only showing events that have occurrences. Then on the events index page (/events) I show all events regardless of having occurrences or not.

mattjstar commented 10 years ago

Just added the ability to add and edit skills related to Events.

carlsednaoui commented 10 years ago

Damn, you're killing it @mattjstar! What can I tackle? Is there anything front-end related (other than "Show all fields http://localhost:3000/organizations/13/edit")?

mattjstar commented 10 years ago

the events index.html.erb file can be styled depending on what you want that to ultimately be?

carlsednaoui commented 10 years ago

Perfect, I'll take care of that — it's likely to look a whole lot like the homepage

mattjstar commented 10 years ago

Just pushed up the ability to add occurrences (so we at least have some sort of MVP).

Have yet to add the ability to edit or delete occurrences.

@carlsednaoui go ahead and look at views/occurrences/_form.html.erb. The helper that I'm using (datetime_local_field) for start_time and end_time only seems to work on chrome:

<div class="form-group row">
    <label for="skills" class="col-sm-2 control-label skill">End Time</label>
    <div class="col-sm-5">
      <%= datetime_local_field(:occurrence, :end_time) %>
    </div>
</div>

Might be worth looking into the https://github.com/Nerian/bootstrap-datepicker-rails gem?

carlsednaoui commented 10 years ago

@mattjstar hmmm, that's weird. I'll take a look at https://github.com/Nerian/bootstrap-datepicker-rails, thanks for suggesting it!

mattjstar commented 10 years ago

@carlsednaoui @miclovich I think we're all good for MVP!

I just added the following: -Admins can "Adminify" users (toggle admin on and off) in the Admin Users view -There's a new Admin Skills view where admins can add and delete skills -I've organized the home page so only events from approved organizations and with future occurrences show up -I've enabled the skill search filter so you can search by skill (that's why I added skills to the view as well, @carlsednaoui you can take them off if you want)

@miclovich if you get the chance, double check the with_skills() method in the pages_controller as it's not sanitized.

I'm unfortunately going to be very busy for the next month or two so I don't see myself getting much time to work on this. Hopefully this is enough for your presentation on Wednesday though!

carlsednaoui commented 10 years ago

@mattjstar this is incredible! Thank you so much for cranking this out so fast, with so much happening in parallel. I'll be working on final tweaks on Monday and I'm sure all the orgs are going to love this!

:rocket: :fire: :100:

miclovich commented 10 years ago

I'll be doing code review throughout the week @mattjstar and pushing some tasks not possible this month to the next sprint

carlsednaoui commented 10 years ago

:+1:

mattjstar commented 10 years ago

amazing thanks @miclovich !