Refactor Skills in Controllers

carlsednaoui / nycio

NYC Tech Volunteer Database

6 stars 2 forks source link

Refactor Skills in Controllers #37

Open mattjstar opened 10 years ago

mattjstar commented 10 years ago

Look at how skills are added to Users and Events in the users_controller, events_controller, and registrations_controller. There might be a more DRY way/cleaner implementation to do this?

carlsednaoui commented 10 years ago

Good call

miclovich commented 10 years ago

Looking it... I guess this issue is still open.

mattjstar commented 10 years ago

yeah it was definitely the functionality was definitely a get this working as quickly as possible solution. Should we consider nested attributes? Or maybe some sort of SkillsSave class that holds all of the logic?