search

carlsednaoui / ouibounce

Increase your landing page conversion rates.
MIT License
2.31k stars 373 forks source link

Add `detectEdges` flag to determine when the user leaves the edge of the window #112

Closed dempfi closed 4 years ago

jgoyon commented 8 years ago

Hi, is there a plan to merge this PR ? I started to implement this feature on my side but discovered the PR of @dempfi already implement it.

dempfi commented 7 years ago

hi @carlsednaoui can you please take a look at this PR?

carlsednaoui commented 7 years ago

Thanks for the note, Ike. As you can see, I've been a bit absent when it comes to open source :(

Will try to jump back into the ouibounce train soon!

On Fri, Feb 17, 2017 at 8:31 AM, Ike Ku notifications@github.com wrote:

hi @carlsednaoui https://github.com/carlsednaoui can you please take a look at this PR?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/carlsednaoui/ouibounce/pull/112#issuecomment-280649770, or mute the thread https://github.com/notifications/unsubscribe-auth/AAwVCjOxkyZoPz3_I5iCkOnSrJnRawekks5rdaEhgaJpZM4HsYu- .

dempfi commented 7 years ago

I know how it happens :) no worries