Adding optional parameters to ouibounce.disable()

carlsednaoui / ouibounce

Increase your landing page conversion rates.

MIT License

2.31k stars 373 forks source link

Closed mcg88 closed 10 years ago

mcg88 commented 10 years ago

Added 2 optional parameters to the .disable() function which allow:

To change the scope of the cookie between site wide or only the current page.
To modify the cookie expiration length. (This would allow a user to use the disable function in different contexts. ie successful form submision and modal exit would have different expiration lengths etc.

Added in a demo for the less aggressive behavior and modified readme.md to include the two parameters along with example code.

jescalan commented 10 years ago

Hey @mcgwebdesign - this looks fantastic, nice work! Is there any chance you would take a crack at writing a test for this? https://github.com/carlsednaoui/ouibounce/blob/master/test/test.js

mcg88 commented 10 years ago

Thanks @jenius! I will give it a shot.

carlsednaoui commented 10 years ago

@jenius, tried to clarify that gnarly ternary logic. Thoughts? 2ff8c3dec94e5b41d97774d46c2bf68a2c1c6e5d

carlsednaoui commented 10 years ago

@mcgwebdesign, let us know if you'll be writing tests for this :smiley:

mcg88 commented 10 years ago

@carlsednaoui I have no experience writing tests, but I will attempt today/tomorrow and let you know :)

thanks!