carlspring / s3fs-nio

A Java (NIO2) FileSystem Provider for Amazon AWS S3.

https://s3fs-nio.carlspring.org/

66 stars 23 forks source link

Improve file attribute caching #855

Closed steve-todorov closed 18 hours ago

steve-todorov commented 3 weeks ago

Pull Request Description

This pull request closes #854.

There are some small breaking changes related to some public methods which were removed as logic for the cache has changed:

S3FileSystem#getCache() method was removed
S3Path#setFileAttributes() was removed.
S3FileSystemProvider#getCache() was removed.
S3FileSystemProvider#setCache() was removed.

Acceptance Test

[x] Building the code with gradle clean build still works.

Questions

Does this pull request break backward compatibility?
- [x] Yes and my commit follows the Conventional Commits Specification
- [ ] No
Does this pull request require other pull requests to be merged first?
- [ ] Yes, please see #...
- [x] No
Does this require an update of the documentation?
- [ ] Yes, please see [provide details here]
- [x] No

steve-todorov commented 3 weeks ago

/deploy-pr

github-actions[bot] commented 3 weeks ago

Status

Snapshot was successfully deployed!
Build logs are available here

Snapshot artifact coordinates:

org.carlspring.cloud.aws:s3fs-nio:PR-855-SNAPSHOT

WARNING

DO NOT USE IN PRODUCTION AS IT WILL BE DELETED AFTER MERGE!
This is a temporary snapshot preview available only for convenience.

steve-todorov commented 2 weeks ago

/deploy-pr

github-actions[bot] commented 2 weeks ago

Status

Snapshot was successfully deployed!
Build logs are available here

Snapshot artifact coordinates:

org.carlspring.cloud.aws:s3fs-nio:PR-855-SNAPSHOT

WARNING

DO NOT USE IN PRODUCTION AS IT WILL BE DELETED AFTER MERGE!
This is a temporary snapshot preview available only for convenience.

steve-todorov commented 2 weeks ago

/deploy-pr

github-actions[bot] commented 2 weeks ago

Status

Snapshot was successfully deployed!
Build logs are available here

Snapshot artifact coordinates:

org.carlspring.cloud.aws:s3fs-nio:PR-855-SNAPSHOT

WARNING

DO NOT USE IN PRODUCTION AS IT WILL BE DELETED AFTER MERGE!
This is a temporary snapshot preview available only for convenience.

steve-todorov commented 2 weeks ago

/deploy-pr

github-actions[bot] commented 2 weeks ago

Status

Snapshot was successfully deployed!
Build logs are available here

Snapshot artifact coordinates:

org.carlspring.cloud.aws:s3fs-nio:PR-855-SNAPSHOT

WARNING

DO NOT USE IN PRODUCTION AS IT WILL BE DELETED AFTER MERGE!
This is a temporary snapshot preview available only for convenience.

steve-todorov commented 2 weeks ago

/deploy-pr

github-actions[bot] commented 2 weeks ago

Status

Snapshot was successfully deployed!
Build logs are available here

Snapshot artifact coordinates:

org.carlspring.cloud.aws:s3fs-nio:PR-855-SNAPSHOT

WARNING

DO NOT USE IN PRODUCTION AS IT WILL BE DELETED AFTER MERGE!
This is a temporary snapshot preview available only for convenience.

carlspring commented 1 day ago

Needs rebasing from master.