carlthome / python-audio-effects

Apply audio effects such as reverb and EQ directly to audio files or NumPy ndarrays.
MIT License
386 stars 53 forks source link

Added "sinc" effect, and a "custom" argument #11

Closed hadware closed 6 years ago

hadware commented 6 years ago

I hope i didn't get too crazy on the inputs checking part on the sinc effect (tried to make it as clear as possible, since the original SoX doc is pretty confusing IMHO).

Also, I figured it'd be better to add a "custom" method to the effects chain, which would enable you to add your own effect string (pretty useful for effects that are not yet implemented). Since now all unimplemented effects can still be used, I think we sould remove all the "empty" methods in on the main object.

carlthome commented 6 years ago

Status?

hadware commented 6 years ago

I fixed most of what you requested. I still need to add the custom method to the unit tests like you requested

carlthome commented 6 years ago

Thanks! 😃