search

carlthome / python-audio-effects

Apply audio effects such as reverb and EQ directly to audio files or NumPy ndarrays.
MIT License
381 stars 52 forks source link

dsp.py - sync code omits a necessary negative sign #27

Open kleydon opened 4 years ago

kleydon commented 4 years ago

According to SoX documentation, a low pass filter is called by the underlying sox library using a negative sign, e.g sinc -4k, however the code in dsp.py ommits this negative sign. As a result, attempts to create a low pass sinc filter result in a high pass sinc filter.

carlthome commented 4 years ago

Yikes, good catch! @kleydon or @hadware care to fix this?

https://github.com/carlthome/python-audio-effects/commit/67408981a1b3c5c5aaacf4915d2de2b149dd9bb0

hadware commented 4 years ago

Right. Can you assign me to the task so I don't forget?

hadware commented 4 years ago

Thanks, sorry I forgot that, I'll correct it ASAP.