carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections

https://django-filter.readthedocs.io/en/main/

Other

4.46k stars 769 forks source link

Update tests for Django 4.1 #1463

Closed carltongibson closed 2 years ago

carltongibson commented 2 years ago

Django 4.1 is showing up an unexpected success in the test suite. (🎩 @bmispelon for https://github.com/django/django/commit/91acfc3)

FAILED (skipped=7, expected failures=3, unexpected successes=1)

Time to clear that up.

First step is just to remove the problem @unittest.expectedFailure and see what the rest of the test suite has to say.

Line was added by @rpkilby in 9f86ae2e95c93153d5bd52f4b2ada83f766a5cf3 for #1060.

codecov-commenter commented 2 years ago

Codecov Report

Merging #1463 (139cc43) into main (ab79783) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1463   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          15       15           
  Lines        1270     1270           
=======================================
  Hits         1263     1263           
  Misses          7        7

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ab79783...139cc43. Read the comment docs.

carltongibson commented 2 years ago

OK, so that all passes. The issue is #1050 — intermittent DST failures that never got looked at.

Let's have it fail intermittently: at least then it will be annoying enough to fix. (I shall have to make @adamchainz show me his time-machine project

bmispelon commented 2 years ago

Always happy to break your test suite 😁

Good luck with your DST issues 🤞🏻