22.1 introduced a backwards incompatible change that is not listed in the changelog

carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections

https://django-filter.readthedocs.io/en/main/

Other

4.42k stars 767 forks source link

22.1 introduced a backwards incompatible change that is not listed in the changelog #1511

Closed lociii closed 1 year ago

lociii commented 2 years ago

Release 22.1 removed compatibility fallbacks that were originally scheduled to be removed in release 2.1

filter_class could still be used instead of filterset_class
filter_fields could still be used instead of filterset_fields

Both were mentioned in the 2.0 migration guide but then forgotten to be removed in 2.1.

IMHO this should be mentioned in the changelog as someone (e.g. me :smiling_face_with_tear:) might still have used them.

Thanks

carltongibson commented 2 years ago

C.I. is broken pending https://github.com/encode/django-rest-framework/pull/8543

codecov-commenter commented 1 year ago

Codecov Report

Merging #1511 (5ad0e22) into main (de3019c) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1511   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files          15       15           
  Lines        1258     1258           
=======================================
  Hits         1251     1251           
  Misses          7        7

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.