carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections
https://django-filter.readthedocs.io/en/main/
Other
4.41k stars 766 forks source link

Deprecated Schema generations #1574

Closed carltongibson closed 1 year ago

carltongibson commented 1 year ago

Closes #1432. Closes #1573.

Related deprecations fix:

codecov-commenter commented 1 year ago

Codecov Report

Merging #1574 (06b04ed) into main (8ac0865) will decrease coverage by 0.87%. The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main    #1574      +/-   ##
==========================================
- Coverage   99.44%   98.58%   -0.87%     
==========================================
  Files          15       15              
  Lines        1259     1271      +12     
==========================================
+ Hits         1252     1253       +1     
- Misses          7       18      +11     
Impacted Files Coverage Δ
django_filters/rest_framework/backends.py 82.35% <50.00%> (-17.65%) :arrow_down:
django_filters/__init__.py 94.73% <100.00%> (+0.98%) :arrow_up:
django_filters/compat.py 90.00% <100.00%> (+30.00%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

carltongibson commented 1 year ago

cc @tfranzel

tfranzel commented 1 year ago

Hey Carlton, sry I was unavailable for some time.

This looks good. I ran our tests against the new release. We never enter those deprecated methods and so we should be safe. :+1:

carltongibson commented 1 year ago

Hey @tfranzel — that's what I like to hear! 🎶 Thanks for all your efforts.