search

carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections
https://django-filter.readthedocs.io/en/main/
Other
4.41k stars 766 forks source link

Refactor read 'README.rst' file to use context manager for file handling #1578

Closed mahdirahimi1999 closed 9 months ago

mahdirahimi1999 commented 1 year ago

Description

This commit updates the read 'README.rst' file to use a context manager when opening the file, ensuring that the file is properly closed after it has been read. This improves the code's readability and helps to prevent potential resource leaks.

mahdirahimi1999 commented 1 year ago

Please check this PR. @carltongibson

mahdirahimi1999 commented 1 year ago

Please check this PR. @carltongibson

carltongibson commented 1 year ago

Hi @mahdirahimi1999. Yes I saw this. Not sure it's really worth it, given that setup.py is a single shot script. (And that it's likely time to move to pyproject.toml and, likely, flit)

carltongibson commented 9 months ago

Thanks but we moved to pyproject.toml

mahdirahimi1999 commented 9 months ago

Ok, good luck @carltongibson