search

carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections
https://django-filter.readthedocs.io/en/main/
Other
4.41k stars 766 forks source link

Fix error when a comma is given as input for an OrderingFilter #1598

Closed munnsmunns closed 9 months ago

munnsmunns commented 1 year ago

Fix FieldError when "," is given as the value for an OrderingFilter. Issue #1597

carltongibson commented 1 year ago

Fancy adding a fix in a second commit?

codecov-commenter commented 1 year ago

Codecov Report

Merging #1598 (2cdb4b0) into main (f38dcdd) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1598   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          15       15           
  Lines        1271     1276    +5     
=======================================
+ Hits         1253     1258    +5     
  Misses         18       18
Files Changed Coverage Δ
django_filters/fields.py 100.00% <100.00%> (ø)
django_filters/filters.py 100.00% <100.00%> (ø)
scott-8 commented 1 year ago

Any update on this PR?

carltongibson commented 1 year ago

Yes, waiting for a reply to https://github.com/carltongibson/django-filter/issues/1597#issuecomment-1694642517

carltongibson commented 9 months ago

Fixed in #1628