search

carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections
https://django-filter.readthedocs.io/en/main/
Other
4.41k stars 766 forks source link

Choice iterator breakage against Django pre-5.0 #1605

Closed carltongibson closed 1 year ago

carltongibson commented 1 year ago

Refs https://github.com/django/django/pull/16943 Refs https://github.com/wagtail/wagtail/pull/10846

  File "/Users/carlton/Projects/Django/django-filter/.tox/py311-latest/lib/python3.11/site-packages/django/forms/fields.py", line 874, in __init__
    self.choices = choices
    ^^^^^^^^^^^^
  File "/Users/carlton/Projects/Django/django-filter/django_filters/fields.py", line 264, in _set_choices
    super()._set_choices(value)
    ^^^^^^^^^^^^^^^^^^^^
AttributeError: 'super' object has no attribute '_set_choices'
carltongibson commented 1 year ago

The initial ChoiceIterator changes are here: