Closed carltongibson closed 1 year ago
Merging #1606 (f279fb7) into main (e5fc05d) will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #1606 +/- ##
==========================================
+ Coverage 98.58% 98.59% +0.01%
==========================================
Files 15 15
Lines 1271 1285 +14
==========================================
+ Hits 1253 1267 +14
Misses 18 18
Files Changed | Coverage Ξ | |
---|---|---|
django_filters/fields.py | 100.00% <100.00%> (ΓΈ) |
Hey @ngnpope π Don't suppose I could ask for your opinion here could I please? π
https://github.com/carltongibson/django-filter/commit/b035bf278ac82254022b639a0a1b08ae66a445a3 is needed to surface the ChoiceIterator issue, otherwise we hit apps not loaded setting up the test run.
This only comes up in tox. (Grrr.) Calling django.setup()
is unobjectionable, and probably should have always been thereβ¦ π€, so unless someone wants to input I'm just going to leave it.
Hey @ngnpope π Don't suppose I could ask for your opinion here could I please? π
Will take a look... π
See #1607 for an alternative π
Thanks @ngnpope π¦ΈββοΈ Looks good. I'll give it a proper read over the weekend. π
Closing in favour of #1607
Refs #1605.
b035bf278ac82254022b639a0a1b08ae66a445a3 is needed to surface the ChoiceIterator issue, otherwise we hit apps not loaded setting up the test run.
(@felixxm don't suppose you know when this snuck in do you? Ta! π)