search

carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections
https://django-filter.readthedocs.io/en/main/
Other
4.39k stars 760 forks source link

Set default value of filterset data to MultiValueDict #1634

Closed sgordon16 closed 4 months ago

sgordon16 commented 6 months ago

fix for issue #1633

codecov-commenter commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (af9f13b) 98.59% compared to head (97ec657) 98.59%. Report is 1 commits behind head on main.

:exclamation: Current head 97ec657 differs from pull request most recent head 390c0f2. Consider uploading reports for the commit 390c0f2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1634 +/- ## ======================================= Coverage 98.59% 98.59% ======================================= Files 15 15 Lines 1283 1284 +1 ======================================= + Hits 1265 1266 +1 Misses 18 18 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

carltongibson commented 5 months ago

If you had capacity though, adding a test that demonstrates the change in behaviour would be handy. Thanks.

sgordon16 commented 5 months ago

If you had capacity though, adding a test that demonstrates the change in behaviour would be handy. Thanks.

Done

sgordon16 commented 5 months ago

I also just want to point out that this is what Django does in the BaseForm class here.

carltongibson commented 5 months ago

@sgordon16 Yes, it's certainly correct. I would have merged it already, but I want to play with a couple of things in the shell, and just haven't had time for that yet.

🎁