search

carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections
https://django-filter.readthedocs.io/en/main/
Other
4.44k stars 767 forks source link

Failing test for ChoiceField eagerly evaluating choices #1648

Closed craigds closed 6 months ago

craigds commented 6 months ago

refs #1625

craigds commented 6 months ago

@carltongibson that should help^

In case it helps, that test passes when backported on top of 23.2 and fails with 23.3

carltongibson commented 6 months ago

Great. Thanks. Let me have a look. 👀

ngnpope commented 6 months ago

Thanks for the ping @carltongibson.

So, yes, it looks as though I was a little too optimistic there - your proposed patch looks like the right approach.

github-actions[bot] commented 6 months ago

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  django_filters
  fields.py
Project Total  

This report was generated by python-coverage-comment-action

craigds commented 6 months ago

thanks, sorry I didn't get around to submitting a proper fix

carltongibson commented 6 months ago

No problem @craigds. The reproduce was the key thing. 🎁