remove `...` in rest_framework.txt to make life easy

carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections

https://django-filter.readthedocs.io/en/main/

Other

4.39k stars 760 forks source link

remove `...` in rest_framework.txt to make life easy #1651

Closed vainl closed 3 months ago

vainl commented 3 months ago

Someone silly like me, who just copies and posts the code snippet with the ..., will get an exception AttributeError: 'ellipsis' object has no attribute 'rsplit'. So let's just remove it and make life easy.

jeremystretch commented 3 months ago

IMO it's very important to retain some indicator that the example does not represent the complete configuration, to avoid confusion.

vainl commented 3 months ago

It's meant to imply there's more there. I'd be happy if you replaced it with a commment # …

Done. I just a comment.

github-actions[bot] commented 3 months ago

Coverage report

This PR does not seem to contain any modification to coverable code.