carltongibson / django-filter

A generic system for filtering Django QuerySets based on user selections
https://django-filter.readthedocs.io/en/main/
Other
4.45k stars 769 forks source link

test models in package #2

Closed ramusus closed 15 years ago

ramusus commented 15 years ago

I think it's a good idea to move models.py to another directory, for example "tests"

Every time, when I update my db-scheme, system ask me to make tables from "django-filter/models.py" file. I don't need these test tables, but I don't think that's right to remove this file from external package.

alex commented 15 years ago

Unfortunately there currently isn't a way to do this. This is an issue with Django itself as seen here: http://code.djangoproject.com/ticket/7835 .

jezdez commented 15 years ago

I don't agree, there are plenty of apps that ship test models, e.g. http://github.com/jacobian/django-shorturls/tree/master/src/shorturls/tests

jezdez commented 15 years ago

FYI, I've fixed this issue in http://github.com/jezdez/django-filter/commit/277f3260bbffeb7822281da2cec7b2fc57f71c94

glezos commented 15 years ago

jezdez, that's awesome. Alex, do you think jezdez's changes could be merged soon?