Rollback pre-5.1 compat changes. - Githubissues

carltongibson / django-template-partials

Reusable named inline partials for the Django Template Language.

MIT License

387 stars 15 forks source link

Rollback pre-5.1 compat changes. #25

Closed carltongibson closed 9 months ago

carltongibson commented 9 months ago

Regression in 88e60b125510a485fe5f4528e0fd3c6173bd2971.

Without adding get_nodes_by_type() to TemplateProxy, an error is introduced loading extends tags.

AttributeError: 'TemplateProxy' object has no attribute 'get_nodes_by_type()'

Possibly:

… caused by timing change in RenderPartialNode.
… adding get_nodes_by_type() is correct. But tests demonstrating this would be needed.

Reverting these changes, and disabling tox run on CI to investigate at leisure.