search

carlverge / jsonnet-lsp

Jsonnet Language Server and Editor Clients
Apache License 2.0
13 stars 4 forks source link

NPE in NodeToValue #15

Open carl-db opened 1 year ago

carl-db commented 1 year ago

Completion asked for completion on a nil node -- NodeToValue should handle this gracefully, but completion also shouldn't be operating on a nil AST node

goroutine 6 [running]:
github.com/carlverge/jsonnet-lsp/pkg/analysis.defaultToValue({0x0, 0x0})
    github.com/carlverge/jsonnet-lsp/pkg/analysis/value.go:317 +0x9c
github.com/carlverge/jsonnet-lsp/pkg/analysis.NodeToValue({0x0?, 0x0?}, {0x101131fa0, 0x140007ba240})
    github.com/carlverge/jsonnet-lsp/pkg/analysis/value.go:472 +0xbb0
github.com/carlverge/jsonnet-lsp/pkg/lsp.(*Server).Completion(0x14000104120, {0x1010be7a0?, 0x140004401e0?}, 0x140004401e0)
    github.com/carlverge/jsonnet-lsp/pkg/lsp/handler.go:345 +0x160
go.lsp.dev/protocol.serverDispatch({0x101132420, 0x14000146640}, {0x101137800, 0x14000104120}, 0x140007b8220, {0x128a8b598, 0x140007ba200})
    go.lsp.dev/protocol@v0.12.0/server.go:206 +0x4154
go.lsp.dev/protocol.ServerHandler.func1({0x101132420, 0x14000146640}, 0x140007b8220, {0x128a8b598, 0x140007ba200})
    go.lsp.dev/protocol@v0.12.0/server.go:36 +0x6c
go.lsp.dev/jsonrpc2.(*conn).run(0x14000146690, {0x101132420, 0x14000146640}, 0x1400000c360)
    go.lsp.dev/jsonrpc2@v0.10.0/conn.go:206 +0x234
created by go.lsp.dev/jsonrpc2.(*conn).Go
    go.lsp.dev/jsonrpc2@v0.10.0/conn.go:189 +0xac