search

carmen-ruby / carmen-rails

NOT ACTIVELY MAINTAINED Rails adapter for Carmen (provides country_select and subregion_select)
MIT License
215 stars 159 forks source link

rails4 compatibility #20

Closed grncdr closed 4 years ago

grncdr commented 11 years ago

Hey, this isn't backwards compatible with rails3, but was necessary to get the form_helper to work with rails4.

Nowaker commented 11 years ago

Is there any reason why it's still not merged? Is the gem maintained?

Using this for now:

gem 'carmen-rails', :git => 'https://github.com/freerunningtechnologies/carmen-rails', :branch => 'rails4'

ghost commented 11 years ago

This gem is still being maintained but is possibly switching owners. Thanks for these pull requests though guys and this is one of the high priority things to review when we are done with the process for carmen-rails migration.

bcm commented 11 years ago

any updates? now that rails 4 is released it would be nice to get a compatible version of carmen released.

bcm commented 11 years ago

ping!

paulkoegel commented 11 years ago

any update? carmen-rails is unusable for me right now =(

brumm commented 11 years ago

:+1:

bcm commented 11 years ago

looks like this got merged instead: https://github.com/jim/carmen-rails/commit/38ea9c04db5e42e469340a2eb712e05356b8d572

I guess @jim wasn't aware we were all watching this issue :)

pcriv commented 10 years ago

is this gem still unusable on rails 4? does anyone know any alternatives?

Nowaker commented 10 years ago

@pablocrivella https://github.com/jim/carmen-rails/pull/20#issuecomment-15022891

Nowaker commented 10 years ago

@freerunningtech Would you mind releasing your https://github.com/freerunningtechnologies/carmen-rails rails4 branch as a gem, e.g. carmen-rails4? The author doesn't care about this gem so you are our last hope.

jim commented 10 years ago

Sorry I haven't gotten around to dealing with this issue yet. If anyone is interested in helping maintain the project, please let me know.

bcm commented 10 years ago

https://github.com/jim/carmen-rails/commit/38ea9c04db5e42e469340a2eb712e05356b8d572 appears to have made the gem rails 4 compatible. looks like somebody just needs to push a new version of the gem.

ghost commented 10 years ago

Sorry guys, been so busy. We could definitely use some help maintaining this.

Nowaker commented 10 years ago

@Jim, the gem from the repo I mentioned, branch rails4, is fully working. Just merge it and you are done.

Kind regards Damian Nowak

-----Original Message----- From: Jim Benton notifications@github.com To: jim/carmen-rails carmen-rails@noreply.github.com Cc: Damian Nowak spam@nowaker.net Sent: Fri, 28 Feb 2014 20:31 Subject: Re: [carmen-rails] rails4 compatibility (#20)

Sorry I haven't gotten around to dealing with this issue yet. If anyone is interested in helping maintain the project, please let me know.

Reply to this email directly or view it on GitHub: https://github.com/jim/carmen-rails/pull/20#issuecomment-36385960

jim commented 10 years ago

@Nowaker That branch doesn't merge cleanly into master, and when I resolve the conflicts, it still has failing tests.

I've just released 1.0.1. Can anyone running into a problem with Rails 4 give it a go and see if it resolves your issues?

alanheppenstall commented 10 years ago

@jim It works great for me in 4.0.0 and in 4.0.3 in a modified version of your example app (https://github.com/alanheppenstall/carmen-rails-example-rails4test)