search

carmen-ruby / carmen-rails

NOT ACTIVELY MAINTAINED Rails adapter for Carmen (provides country_select and subregion_select)
MIT License
215 stars 159 forks source link

Add in missing html_options param for "subregion_select_tag" #34

Closed bbuck closed 6 years ago

bbuck commented 11 years ago

country_select_tag passes html_options to subregion_select_tag which did not accept html_options thus loosing any modifications to the HTML for the country_select_tag.

bbuck commented 11 years ago

Sorry, I wrote that wrong. This actually adds the HTML options to the country_select_tag which doesn't current accept them or pass them forward.

prathamesh-sonpatki commented 11 years ago

@jim Any plans on merging this

jim commented 11 years ago

@bbuck Thanks for the fix! Sorry for the delay in getting back to you.

Would you be willing to add a test to this PR before it gets merged in? Looks like this was an oversight, and that would help prevent a similar regression in the future.

prathamesh-sonpatki commented 11 years ago

@jim Tests are right now failing. We are getting latest release of Rails from gemspec. And Rails 4 has changed somethings. It works fine with 3.2.x.

Should we release separate versions for 3.2.x and 4.x?

jboler commented 10 years ago

It would be really nice to get this merged in. Seems like it's a really trivial fix?

ckgagan commented 9 years ago

@jim Please merge this pull request. I needed it too :)