search

carmen-ruby / carmen-rails

NOT ACTIVELY MAINTAINED Rails adapter for Carmen (provides country_select and subregion_select)
MIT License
215 stars 159 forks source link

Add option to show the region code in the select option text #48

Closed thiagoa closed 9 years ago

thiagoa commented 10 years ago

Hi,

This feature allows you to present the region code instead of the region name in the select option text. In some countries it's commonplace to use the region code to represent country states; It's also useful when your select box is in a constrained space, and you need a shorter text inside.

thiagoa commented 10 years ago

The build seems to be failing because test data is expected to be in a certain directory, inside the carmen project. All Appraisal tests passed on my machine. RubyGems seems to skip any directory which begins with spec when installing gems, otherwise we could use the Bundler path to access test data.

One possible solution is to duplicate the test data into carmen-rails ... after all it's just test data. I will take a careful look at this, If I'm allowed to, when I get back home.