search

carmen-ruby / carmen-rails

NOT ACTIVELY MAINTAINED Rails adapter for Carmen (provides country_select and subregion_select)
MIT License
215 stars 159 forks source link

Rails support for Rails 4.2 #57

Open jtapia opened 9 years ago

jtapia commented 9 years ago
ecbypi commented 9 years ago

It's still failing because it thinks the Gemfile has been changed. I'm not sure why, but it would be nice to see if it's reproducible on your local dev environment.

I would take out updating the version. I think it's best to keep the feature change independent of incrementing the version so features can be reverted without affecting the version number.

jtapia commented 9 years ago

@ecbypi got it, and done, I removed the update of version

jtapia commented 9 years ago

I can't reproduce it locally, and neither send the new Gemfile.lock, because maybe we're using different versions

ecbypi commented 9 years ago

@jtapia, found another instance of the bundler problem. Searching through bundler's issues, I'm able to find issues with a similar error message, but nothing that exactly mirrors our problem. I'm trying to run the build with an updated version of bundler.

http://stackoverflow.com/questions/26221540/gemspec-modification-up-to-date-gemfile-lock-does-break-the-travis-ci-build-d

jtapia commented 9 years ago

@ecbypi Ok, let me take a look and see if I can find a solution, is it for Travis CI, right?