search

carmen-ruby / carmen-rails

NOT ACTIVELY MAINTAINED Rails adapter for Carmen (provides country_select and subregion_select)
MIT License
215 stars 159 forks source link

Country Subregion sort #9

Closed rdsoze closed 12 years ago

rdsoze commented 12 years ago

Removing the unpack('U') was sorting the countries and states in the correct order.

jim commented 12 years ago

Thanks for the fix. I think the unpack was there in an attempt to handle certain unicode strings but it was breaking sorting as you identified.

charlesdeb commented 11 years ago

I see that this is merged into the master and it does work for me, but it hasn't yet been updated to the rubygems repository. Any chance this could be uploaded (or version bumped...) and maybe save someone else an hour or so of trying to work out why countries aren't being sorted? Thanks for your work on this fix - although yes, I now have the Aland Islands (with a wee dot above the A at the bottom of my list... I guess the folks from there are used to it!)