search

carmenalab / brain-python-interface

Other
6 stars 8 forks source link

Missing trial data analysis functions #30

Open TomekFraczek opened 5 years ago

TomekFraczek commented 5 years ago

The TaskEntry wrapper object tries, in several places, to import three files of functions that do not exist anywhere in the path, and I can't find a reference to them in the docs.

https://github.com/carmenalab/brain-python-interface/blob/87c3c10c5bcce5201ba926eecea3afde568fef0c/db/dbfunctions.py#L597

https://github.com/carmenalab/brain-python-interface/blob/2939180a93a7015a00bd1fe992723524fc5a13e3/db/dbfunctions.py#L1108

https://github.com/carmenalab/brain-python-interface/blob/2939180a93a7015a00bd1fe992723524fc5a13e3/db/dbfunctions.py#L1207

What should these files look like? Are they still expected to be there?

sgowda commented 5 years ago

these files are in the analysis folder in the bmi3d_tasks_analysis repo. splitting analysis and db code was poorly done (by me). that dependency should not exist, probably by removing the imports and corresponding code.