carmineos / rage-toolkit

Other
19 stars 6 forks source link

Fix wrapper not deleting buf #37

Closed xZToxicZx closed 1 year ago

xZToxicZx commented 1 year ago

I found this due to attempting to load multiple dds files at once.

carmineos commented 1 year ago

Looks legit, could you squash the 2 commits? Otherwise I'll just squash and merge myself

Also note that the idea was to move DDS handling to full managed code, you can check some initial work @ dev/ddsio

xZToxicZx commented 1 year ago

I squashed them locally threw vs, hope that this is correct? Never really had to do it before, also I believe that commits get squashed by PRs anyway, depending on how you have them setup.

xZToxicZx commented 1 year ago

36

carmineos commented 1 year ago

Yes I can choose to squash them when merging, that's what I did since you didn't force push so your PR would have added 4 commits