carmonalab / ProjecTILs

Interpretation of cell states using reference single-cell maps
GNU General Public License v3.0
234 stars 27 forks source link

Classes of existing metadata change upon projection #17

Closed ktrns closed 2 years ago

ktrns commented 2 years ago

Dear all,

Thank you for developing ProjecTILs!

While I am trying out your package, I noticed that classes of the existing metadata are changed after projection.

ref = ProjecTILs::load.reference.map()
sc_projectils = ProjecTILs::make.projection(sc, ref=ref, skip.normalize=TRUE)
Screenshot 2021-08-17 at 10 40 19

Maybe this is something you can fix?

Best wishes and thanks a lot for your work! Katrin

ktrns commented 2 years ago

Hey there,

Me again, once more. Just to let you know... After the above projection command, the following new metadata columns exist but are empty: Sample, Barcode, percent.ribo, percent.mito, Study, functional.cluster, whereby the last one is filled after I called cellstate.predict.

I will work around this, temporarily store the additional Seurat object, extract the relevant filled metadata columns, and add them to my metadata.

Best wishes & thanks Katrin

ktrns commented 2 years ago

Hey there,

Last post for today :-). I noticed you also change rownames of the metadata of my (query) Seurat object to "Q_".

Ideally, as far as I understand it, you wouldn't change my existing metadata table, and just add new columns, because in this case, I wouldn't have to create a second (big) Seurat object.

Best wishes, thanks & have a nice day Katrin

sjcarmona commented 2 years ago

Hi Katrin,

Thank you for your feedback and for reporting this issue! we'll work on it

mass-a commented 2 years ago

Hello Katrin!

these issues with the metadata classes should be solved in the newest release of ProjecTILs.

Best -m