carnager / clerk

clerk - mpd client, based on rofi/fzf
MIT License
216 stars 11 forks source link

clerk won't launch rofi #33

Closed fishman closed 7 years ago

fishman commented 7 years ago

How does clerk launch rofi? I see references to it in the code and i see the rvar{backend} = 'rofi' but there i can't get it to launch rofi.

carnager commented 7 years ago

see clerk -h all arguments actually start rofi, except when using -f option.

fishman commented 7 years ago

Rasmus Steinke notifications@github.com writes:

see clerk -h all arguments actually start rofi, except when using -f option.

I see that, but still for me it will only start tmux with fzf.

carnager commented 7 years ago

that's very strange indeed. I just tried what happens if no rofi is installed.

carnager@caprica ~ > clerk -t
Command 'rofi' not found in /home/carnager/.gem/ruby/2.4.0/bin, /home/carnager/bin, /home/carnager/perl5/bin, /home/carnager/bin, /usr/local/sbin, /usr/local/bin, /usr/bin, /usr/lib/jvm/default/bin, /usr/bin/site_perl, /usr/bin/vendor_perl, /usr/bin/core_perl at /usr/bin/clerk line 263.

as expected...

fishman commented 7 years ago

hmm is there anything special in your clerk.conf?

Rasmus Steinke notifications@github.com schrieb am So., 22. Okt. 2017 um 20:55 Uhr:

that's very strange indeed. I just tried what happens if no rofi is installed.

carnager@caprica ~ > rofi -t zsh: command not found: rofi

as expected...

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/carnager/clerk/issues/33#issuecomment-338500389, or mute the thread https://github.com/notifications/unsubscribe-auth/AABCz3a79X8l9xA7Z7St90IdjlHa8mfvks5su4-8gaJpZM4QB7EL .

carnager commented 7 years ago

no...

[General]
# MPD_HOST will override this
mpd_host=tauron

# music root for rating_client
music_root=/mnt/wasteland/Audio/Rips

# define file paths
database=/home/carnager/.config/clerk/database.mpk
tmux_config=/home/carnager/.config/clerk/clerk.tmux

# player for queue tab
player=ncmpcpp

# number of songs clerk will get at once for creating its cache files
songs=20

# if mpd drops the connection while updating, reduce this.
chunksize=30000

# enable this to jump to queue after adding songs in tmux ui.
jump_queue=true

# Use albumartist or artist for random tracks?
randomartist=albumartist

# write tags to audio files. Needs running clerk_rating_client on machine with audio files
# ratings will always be written to sticker database.
tagging=false

[Columns]
# width of columns
albumartist_l=50
album_l=118
artist_l=66
date_l=6
title_l=50
track_l=2
rating_l=4

I am curious, but simply cannot reproduce it. And codewise $rvar{backend} is only set to fzf when "-f" is passed.

long shot, but is your rofi actually working? echo "foo" | rofi -dmenu"

carnager commented 7 years ago

can you try clerk --no-tmux-ui -t

fishman commented 7 years ago

that works

carnager commented 7 years ago

Ok, guess i will document that option, just in case. still strange :)

eyadsibai commented 4 years ago

same issue! would be nice to have it in the documentation