search

carnager / rofi-pass

rofi frontend for pass
GNU General Public License v3.0
697 stars 122 forks source link

Heads-up: rofi-pass is now packaged on FreeBSD #157

Open 0mp opened 5 years ago

0mp commented 5 years ago

Here's a link for more details: https://www.freshports.org/x11/rofi-pass/

Cheers!

moviuro commented 5 years ago

Were there any issues without GNU grep and awk?

Both are listed as dependencies (see README.md, when we probably could do without.

0mp commented 5 years ago

I am not sure, really. I've not tested in personally; I just wanted to share the good news.

I'll let the maintainer about this thread we have here so that they could chime in.

xanderio commented 5 years ago

Well I added them to the dependencies because you list them in README.md. I will do some testing and report my finding back to you.

moviuro commented 5 years ago

@Xanderio I like shipping portable scripts, and rofi-pass doesn't do any sort of dark magic AFAICT, so it should be feasible to rely only on POSIX options that FreeBSD grep and awk do implement (possibly even making an OpenBSD port possible in the process).

xanderio commented 5 years ago

I did some testing and it appears the GNU grep/awk are not needed for rofi-pass to work. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236225

moviuro commented 5 years ago

Might be worth reflecting those in README.md and making sure future contributions use POSIX options for grep and awk. (I remember doing something similar for openRA)

xanderio commented 5 years ago

fyi:

Hi,

I did a pass over this to make sure it wasn't using grep features that we don't quite support but don't treat as errors -- that turned out alright, but it turns out the sed usage is slightly wrong in one place [1] for our world.

I would recommend sending a patch upstream to change this to the more portable expression sed -Ee 's/[[:blank:]]+$//', though it's probably not critical to patch it locally since it just strips whitespace off the end (or doesn't, as the case is now =)).

Thanks,

Kyle Evans

[1] https://github.com/carnager/rofi-pass/blob/master/addpass#L56

On Tue, 05. Mar 00:44, Moviuro wrote:

Might be worth reflecting those in README.md and making sure future contributions use POSIX options for grep and awk. (I remember doing something similar for openRA)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.*