search

carnager / rofi-pass

rofi frontend for pass
GNU General Public License v3.0
699 stars 121 forks source link

Problems when not using a gui editor #168

Open cold-reaver opened 5 years ago

cold-reaver commented 5 years ago

Hey,

If not using gvim but vim/nvim/nano etc rofi-pass does not launch a terminal (unless rofi pass is being launched from a terminal, then all works normal). Maybe I am doing something wrong though, but with a small edit I made it work

EDITOR=$EDITOR PASSWORD_STORE_DIR="${root}" termite -e "pass edit \"${selected_password}\""

This is for termite, maybe the best solution is to use $TERMINAL or rofi-sensible-terminal and/or maybe configurable in the config.

What do you think?

podocarp commented 3 years ago

Like you said, can't the user use rofi-sensible-terminal -e vi or whatever terminal editor they want? Anyway thanks for that, I was wondering why rofi pass wasn't opening an editor for me. I think it's an good solution.