search

carnager / rofi-pass

rofi frontend for pass
GNU General Public License v3.0
699 stars 121 forks source link

Fix hardcoded version number #202

Open smartlitchi opened 4 years ago

smartlitchi commented 4 years ago

This pull request fixes #200.

moviuro commented 4 years ago

Wouldn't that break in production? git isn't a dependency of rofi-pass; and a version number should be hardcoded in packaged versions.

smartlitchi commented 4 years ago

You are absolutely right. I haven't thought about that. It's one of my first pull requests so I still lack experience. I will try to find a better way

smartlitchi commented 4 years ago

I couldn't find a simple way to get the version number without hardcoding it so at least I changed the version number to the correct one.