carnager
commented
8 months ago i am not sure if i like the implementation, since it's fragile. What if the name of the gpg file changes? What if users dont want to include the urls in their filenames? And if there is a way to make this work without: why are the icons not encrypted? (it's possible to guess the pages based on their icons in many cases)
This should be handled differently. rofi-pass should have a way to download an icon when opening the entry, based on the url set in the password entry itself, store it and encrypt it using the same gpg key used for the vault. Then, when running rofi-pass decrypt the icons and display them.
This would solve some of the privacy issues, but also add a lot of overhead esp. when dealing with lots of entries. And it gets even more messy when multiple gpg keys are used.
I am open for this idea, since it can be useful to identify entries in your vault. But it's not an easy task to implement the way that pass itself works
I have made a simple mockup based on passmenu before learning about this script that allows for me to have icons in rofi based on the url. Example of what it can look like:
Link to repo with an example: https://github.com/benmac31/rofi-pass-icons
Would this be a feature that a PR would be accepted for (assuming I made it more polished and make it work with more file organization formats.)