carnager / rofi-pass

rofi frontend for pass
GNU General Public License v3.0
696 stars 122 forks source link

add native wayland support #231

Closed lilyinstarlight closed 1 year ago

lilyinstarlight commented 1 year ago

This adds support for auto-typing using wtype and clipboard interaction using wl-clipboard

I think I based this on #214 when I wrote this patch a good while ago, so I've included @plattfot as a co-author

The xdotool_delay config variable was renamed to type_delay since it's been generalized, although xdotool_delay should still work just fine with the backwards compat bit I added

I've used this patch myself with https://github.com/lbonn/rofi (Rofi Wayland fork) for a long while now and it seems to work pretty well

Supersedes and closes #214

carnager commented 1 year ago

can you add an alias from xdotool_delay to type_delay and a warning that xdotool_delay will be deprecated?

lilyinstarlight commented 1 year ago

can you add an alias from xdotool_delay to type_delay and a warning that xdotool_delay will be deprecated?

Right now it sets type_delay=${xdotool_delay} when xdotool_delay is set (providing backwards compat). Is that enough of an alias, or would you rather something else?

I'll go ahead and add a warning when it's used, though. Thanks for the review!

carnager commented 1 year ago

can you add an alias from xdotool_delay to type_delay and a warning that xdotool_delay will be deprecated?

Right now it sets type_delay=${xdotool_delay} when xdotool_delay is set (providing backwards compat). Is that enough of an alias, or would you rather something else?

I'll go ahead and add a warning when it's used, though. Thanks for the review!

That's fine, yes, but a warning would still be good, no need to keep outdated functions

lilyinstarlight commented 1 year ago

That's fine, yes, but a warning would still be good, no need to keep outdated functions

It should be updated with a warning now. Let me know if that's sufficient

Thanks again!

carnager commented 1 year ago

thanks a lot.